Extend documentation of rustc_on_unimplemented
#53279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
estebank
force-pushed
the
on-unimplemented-doc
branch
from
5e66fb9 to
7688091
Compare
estebank
force-pushed
the
on-unimplemented-doc
branch
from
7688091 to
54e11c9
Compare
| = note: required by `iterate_chars` | ||
| ``` | ||
|
|
||
| To allow for more targeted error messages, it is possible to filter the |
There was a problem hiding this comment.
"To allow more targeted"?
|
This is awesome! Thanks a lot! Except for the small nit I saw, it looks good to me. However I'd prefer if an english native speaker would double check this. Otherwise r=me. |
|
@steveklabnik can you give it a pass to verify we don't have any incorrect/obtuse language here? |
|
@GuillaumeGomez we can follow up on a separate PR if there's any wording issue (I want to have something to link people when they ask how to use this). @bors r=GuillaumeGomez |
|
📌 Commit d35e267 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 15, 2018
…illaumeGomez Extend documentation of `rustc_on_unimplemented`
bors
added a commit
that referenced
this pull request
Aug 15, 2018
Rollup of 8 pull requests Successful merges: - #52453 (improve diagnostics for tests with custom return values) - #53271 (use ? to simplify `TransitiveRelation.maybe_map`) - #53279 (Extend documentation of `rustc_on_unimplemented`) - #53342 (fix error for unsized packed struct field) - #53344 (Add doc examples for std::alloc::{alloc,alloc_zeroed}.) - #53368 (Ignore test that fails on stage1) - #53388 (Fix links' color) - #53396 (Fix since of Iterator::flatten to be a proper semver) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.